Improve cached_classproperty type annotations#6341
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6341 +/- ##
==========================================
+ Coverage 72.15% 72.19% +0.04%
==========================================
Files 159 159
Lines 20645 20675 +30
Branches 3269 3268 -1
==========================================
+ Hits 14897 14927 +30
Misses 5041 5041
Partials 707 707
🚀 New features to boost your workflow:
|
Member
|
What does addition of T2 solve/improve here? I'm fine with the new |
Contributor
Author
|
T is the class the decorated method belongs to, T2 is it's return type |
Member
|
Do you know if it's possible to somehow force |
amogus07
force-pushed
the
cached-classproperty
branch
from
ed0f50d to
4b222ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Basically a followup to #6110
To Do
DocumentationChangelogTests